Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support setting ACLs on file paths longer than MAX_PATH #92460

Merged
merged 2 commits into from
Sep 22, 2023
Merged

Support setting ACLs on file paths longer than MAX_PATH #92460

merged 2 commits into from
Sep 22, 2023

Conversation

karakasa
Copy link
Contributor

@karakasa karakasa commented Sep 22, 2023 •
edited
Loading

fix #91980

by guarding FileSystemSecurity.Persist(string) with PathInternal.EnsureExtendedPrefixIfNeeded, as the ctor does.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Sep 22, 2023
@ghost
Copy link

ghost commented Sep 22, 2023

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details

fix #91980

Author: karakasa
Assignees: -
Labels:

area-System.IO
Milestone: -

@karakasa karakasa changed the title Support setting ACLs with file paths longer than MAX_PATH Support setting ACLs on file paths longer than MAX_PATH Sep 22, 2023
adamsitnik
adamsitnik reviewed Sep 22, 2023
View reviewed changes
Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for a very elegant fix!

PTAL at my comment regarding the test.

src/libraries/System.IO.FileSystem.AccessControl/tests/FileSystemAclExtensionsTests.cs Show resolved Hide resolved
adamsitnik
adamsitnik approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for your contribution @karakasa !

src/libraries/System.IO.FileSystem.AccessControl/tests/FileSystemAclExtensionsTests.cs Show resolved Hide resolved
src/libraries/System.IO.FileSystem.AccessControl/tests/FileSystemAclExtensionsTests.cs Outdated Show resolved Hide resolved
@karakasa @adamsitnik
Simplify test with Math.Max
523347f 
Co-authored-by: Adam Sitnik <adam.sitnik@gmail.com>
@build-analysis build-analysis bot mentioned this pull request Sep 22, 2023
Closed
@adamsitnik adamsitnik merged commit 2f7276e into dotnet:main Sep 22, 2023
106 checks passed
@adamsitnik adamsitnik added this to the 9.0.0 milestone Sep 22, 2023
@karakasa karakasa deleted the issue-91980 branch September 22, 2023 23:25
@ViktorHofer
Copy link
Member

Should this be backported into .NET 8?

@ghost ghost locked as resolved and limited conversation to collaborators Oct 25, 2023
@AliveDevil AliveDevil mentioned this pull request Aug 20, 2024
Open
@jeffhandley
Copy link
Member

/backport to release/8.0-staging

@github-actions github-actions bot unlocked this conversation Nov 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 9, 2024

Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/11759736213

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vitek-karas vitek-karas vitek-karas left review comments

@ViktorHofer ViktorHofer ViktorHofer left review comments

@adamsitnik adamsitnik adamsitnik approved these changes

Assignees
No one assigned
Labels
area-System.IO community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.

System.IO.FileSystem.AccessControl can't set ACLs on files with long paths
5 participants
@karakasa @ViktorHofer @jeffhandley @adamsitnik @vitek-karas